Validator CSS Parsing. #996
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We only parse things once for each call to parseAStylesheet, instead of reparsing parts of the parse tree multiple times.
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
|
I signed it! |
|
LGTM |
| sheet.value = consumeAListOfRules(tokenStream, /*topLevel=*/true, errors); | ||
| sheet.line = sheet.value[0].line; | ||
| sheet.col = sheet.value[0].col; | ||
| /** @type {!Canonicalizer} */ |
There was a problem hiding this comment.
Type is inferrable here.
|
Looks like just a few minor things. Please fix and I'll LGTM. |
|
LGTM + followup |
Closed
dvoytenko
added a commit
that referenced
this pull request
Dec 1, 2015
AMP Validator Linting. Changes suggested in #996.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clean up all of the types. No more type unions. We only parse things once for each call to parseAStylesheet, instead of reparsing parts of the parse tree multiple times.