Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start running unit tests on Chrome 37 again. #991

Merged
merged 1 commit into from
Dec 1, 2015
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,5 +22,10 @@ script:
- gulp build
- gulp dist
- gulp presubmit
# Unit tests with Travis' default chromium
- gulp test
# Integration tests with all saucelabs browsers
- gulp test --saucelabs --integration
# All unit tests with an old chrome (best we can do right now to pass tests
# and not start relying on new features).
- gulp test --saucelabs --oldchrome
8 changes: 6 additions & 2 deletions build-system/tasks/test.js
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,10 @@ function getConfig() {
if (!process.env.SAUCE_ACCESS_KEY) {
throw new Error('Missing SAUCE_ACCESS_KEY Env variable');
}
return extend(obj, karmaConfig.saucelabs);
const c = extend(obj, karmaConfig.saucelabs);
if (argv.oldchrome) {
c.browsers = ['SL_Chrome_37']
}
}

return extend(obj, karmaConfig.default);
Expand Down Expand Up @@ -89,6 +92,7 @@ gulp.task('test', 'Runs tests in chrome', ['build'], function(done) {
'saucelabs': ' Runs test on saucelabs (requires setup)',
'safari': ' Runs tests in Safari',
'firefox': ' Runs tests in Firefox',
'integration': 'Run only integration tests.'
'integration': 'Run only integration tests.',
'oldchrome': 'Runs test with an old chrome. Saucelabs only.',
}
});