AMP List overflow fallback and relax some restrictions on change height #978
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| height using the normal AMP flow. | ||
| height using the normal AMP flow. If AMP Runtime cannot satisfy the request for new | ||
| height, it will display `overflow` element when available. Notice however, the typical | ||
| placement of `amp-list` elements at the bottom of the document almost always guarantees |
There was a problem hiding this comment.
remove extra space. of[space][space]amp-list
|
LGTM |
| this.overflowElement_.classList.toggle('amp-hidden', false); | ||
| this.overflowElement_.onclick = () => { | ||
| this.overflowElement_.classList.toggle('amp-hidden', true); | ||
| this.changeHeight(actualHeight); |
There was a problem hiding this comment.
we don't need to deferMutate here right?
There was a problem hiding this comment.
No, because requestChangeHeight is already a deferMutate :)
dvoytenko
added a commit
that referenced
this pull request
Nov 20, 2015
AMP List overflow fallback and relax some restrictions on change height
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #975.