fix(tool): filter non PR merges from changelog. #971
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -205,9 +205,15 @@ function onGitTagSuccess(gitMetadata, tag) { | |||
|
|
|||
| function onGitLogSuccess(gitMetadata, logs) { | |||
| var commits = logs.split('\n'); | |||
There was a problem hiding this comment.
Please in a follow up add a few asserts for the return value of the API.
There was a problem hiding this comment.
got it. this is coming from git log, so this was more a string parsing bug.
|
LGTM |
erwinmombay
added a commit
that referenced
this pull request
Nov 19, 2015
fix(tool): filter non PR merges from changelog.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.