Implement a mechanism for AMP integrations to request an identifier for the current client. #963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| class Cid { | ||
| /** @param {!Window} win */ | ||
| constructor(win) { | ||
| /** @const */ |
cramforce
force-pushed
the
cid
branch
2 times, most recently
from
ec9e63c to
0b2ac28
Compare
|
Comments addressed. Thanks for the awesome review! |
|
LGTM |
for the current client. Misses the following aspects from the spec: - delegation of id generation to viewer. For details see https://goo.gl/Mwaacs
cramforce
added a commit
that referenced
this pull request
Nov 19, 2015
Implement a mechanism for AMP integrations to request an identifier for the current client.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements large parts of #961.
Misses the following aspects from the spec:
For details see https://goo.gl/Mwaacs