Fix bug where all .js urls in samples were changed to .max.js #912
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hose not related to AMP
| @@ -321,7 +321,7 @@ function buildExample(name) { | |||
| console.log('Processing ' + name); | |||
| var html = fs.readFileSync(input, 'utf8'); | |||
| var max = html; | |||
| max = max.replace(/\.js/g, '.max.js'); | |||
There was a problem hiding this comment.
Out of curiosity: What others are there?
There was a problem hiding this comment.
This was the use case that bit me:
<amp-gist data-src="https://gist.github.com/.../foo.js">
|
LGTM |
jmadler
added a commit
that referenced
this pull request
Nov 16, 2015
Fix bug where all .js urls in samples were changed to .max.js
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix bug where all .js urls in samples were changed to .max.js, even those not impacted by gulp (e.g. external urls in src attributes of embed tags)