Create srcset in #layoutCallback #8361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Each srcset takes ~.2ms (for 2 possibles selections) to parse and create. Moving this into `#layoutCallback` saves us from doing that when we parse _every_ image on the page.
cramforce
approved these changes
Mar 24, 2017
mrjoro
pushed a commit
to mrjoro/amphtml
that referenced
this pull request
Apr 28, 2017
Each srcset takes ~.2ms (for 2 possibles selections) to parse and create. Moving this into `#layoutCallback` saves us from doing that when we parse _every_ image on the page.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Each srcset takes ~.2ms (for 2 possibles selections) to parse and
create. Moving this into
#layoutCallbacksaves us from doing that whenwe parse every image in the DOM.
Fixes #8359.