Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache SW: Ensure any failure is always logged. #8328

Merged
merged 3 commits into from
Mar 22, 2017
Merged

Cache SW: Ensure any failure is always logged. #8328

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f10f0ed
Ensure any failure is always logged.
jridgewell Mar 17, 2017
2e6647a
lint
jridgewell Mar 22, 2017
c8fb6b0
Tell closure compiler it'll be alright.
jridgewell Mar 22, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/service-worker/core.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -595,7 +595,7 @@ export function handleFetch(request, maybeClientId) {

// Wait for the cachePromise to resolve. This is necessary
// since the SW thread may be killed and restarted at any time.
return cachePromise.then(() => {
return /** @type {!Promise<!Response>} */ (cachePromise.then(() => {
// If we already registered this client, we must always use the same
// version.
if (clientsVersion[clientId]) {
Expand Down Expand Up @@ -624,7 +624,11 @@ export function handleFetch(request, maybeClientId) {
// If not, let's fetch and cache the request.
return fetchJsFile(cache, versionedRequest, pathname, version);
});
});
}).catch(err => {
// Throw error out of band.
Promise.reject(err);
throw err;
}));
}


Expand Down