Tune heuristic when to load ads. #819
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests failed. Automated cross-browser testing via Sauce Labs and Travis CI shows that the JavaScript changes in this pull request are: BUSTED Commit: 363e144f4449eacca67e4173e6b9084ad0a38bef (Please note that this is a fully automated comment.) |
| @@ -205,6 +229,14 @@ export function installAd(win) { | |||
|
|
|||
| /** @override */ | |||
| layoutCallback() { | |||
| console.error('ADLAYOUT') | |||
|
LGTM with few comments. |
cramforce
force-pushed
the
prefetch
branch
2 times, most recently
from
ae7dbe2 to
cb24f92
Compare
cramforce
changed the title
Instead of only loading them when they are in viewport, we also load them if they are outside the viewport: - if the user has ever scrolled (So we don't interfere with e.g. swiping through articles). - we haven't started loading another ad in the last second. In practice this should load a large percentage of ads before they enter the viewport while interference with scrolling is kept to a similar value as with the old heuristic.
cramforce
added a commit
that referenced
this pull request
Nov 3, 2015
Tune heuristic when to load ads.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of only loading them when they are in viewport, we also load
them if they are outside the viewport:
In practice this should load a large percentage of ads before they enter the viewport
while interference with scrolling is kept to a similar value as with the old heuristic.