Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URL prefetching, Ads preconnect and prefetching and Safari preconnect #805

Merged
merged 1 commit into from
Oct 30, 2015

Conversation

cramforce
Copy link
Member

  • Implements URL prefetching and uses it in a few places where it makes sense.
  • Adds the capability for ad networks to preconnect and prefetch resources
    before being actually loaded.
  • Adds a preconnect polyfill, mostly for Safari, that should speed up
    3p embeds on Safari.
  • Optimizes prefetch for 3p iframe to correctly prefetch custom bootstrap
    iframes and to also prefetch the 3p frame base script.

@cramforce cramforce force-pushed the prefetch branch 3 times, most recently from 16a9c14 to 65023ba Compare October 30, 2015 22:27
@cramforce cramforce force-pushed the prefetch branch 2 times, most recently from 2d4d8c2 to 7025483 Compare October 30, 2015 22:43
@@ -0,0 +1,43 @@
/**
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why underscore in file?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe a bad idea. I kinda wanted this to stand out since it needs to be updated a lot.

@dvoytenko
Copy link
Contributor

LGTM with a couple of comments.

… sense.

Adds the capability for ad networks to preconnect and prefetch resources
before being actually loaded.

Adds a preconnect polyfill, mostly for Safari, that should speed up
3p embeds on Safari.

Optimizes prefetch for 3p iframe to correctly prefetch custom bootstrap
iframes and to also prefetch the 3p frame base script.
cramforce added a commit that referenced this pull request Oct 30, 2015
URL prefetching, Ads preconnect and prefetching and Safari preconnect
@cramforce cramforce merged commit 94e30f4 into ampproject:master Oct 30, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants