Allow iframes to be loaded from data URIs. #793
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cramforce
force-pushed
the
iframe-uris
branch
2 times, most recently
from
291b58c to
e090316
Compare
| 'allow-same-origin is not allowed with the srcdoc attribute %s.', | ||
| this.element); | ||
| var dataUri = 'data:text/html;charset=utf-8;base64,' + btoa(srcdoc); | ||
| this.element.setAttribute('src', dataUri); |
There was a problem hiding this comment.
If all the same, I'd rather if amp-iframe kept the original srcdoc and transformation would only be done to set on iframe element.
|
LGTM with one comment. |
cramforce
force-pushed
the
iframe-uris
branch
from
e090316 to
057dd52
Compare
cramforce
force-pushed
the
iframe-uris
branch
from
057dd52 to
65a363b
Compare
cramforce
added a commit
that referenced
this pull request
Oct 30, 2015
Allow iframes to be loaded from data URIs.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #405