add expectedError method #6581
Merged
add expectedError method #6581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erwinmombay
force-pushed
the
log-update
branch
2 times, most recently
from
da3b87c to
52460dd
Compare
dvoytenko
suggested changes
Dec 9, 2016
| expectedError(tag, var_args) { | ||
| const error = this.error(tag, var_args); | ||
| if (error) { | ||
| error.expected = true; |
There was a problem hiding this comment.
While correct, it's a bit weird to set flag on an error after it's been reported. Maybe better refactor call into a private method and call from both methods with different flags?
There was a problem hiding this comment.
yeah i can do that, that was actually the original code i had written.
erwinmombay
force-pushed
the
log-update
branch
from
52460dd to
4bc5a5f
Compare
|
@dvoytenko changes made. PTAL |
jridgewell
reviewed
Dec 9, 2016
| */ | ||
| error(tag, var_args) { | ||
| error_(tag, var_args) { |
| expectedError(tag, var_args) { | ||
| const error = this.error_.apply(this, arguments); | ||
| if (error) { | ||
| error.expected = true; | ||
| this.win.setTimeout(() => {throw error;}); |
There was a problem hiding this comment.
Don't we have a rethrowAsync?
There was a problem hiding this comment.
yeah, i think it calls createErrorVarArgs again though
|
@jridgewell can you point out to me what the expectedError is in xhr? |
dvoytenko
approved these changes
Dec 9, 2016
|
Ping. |
|
@jridgewell sorry bout that, will finish this today. got caught up in this other issue |
erwinmombay
force-pushed
the
log-update
branch
2 times, most recently
from
ac0dc33 to
5ec84cb
Compare
erwinmombay
commented
Dec 16, 2016
| @@ -394,7 +394,7 @@ function createXhrRequest(method, url) { | |||
| xhr = new XDomainRequest(); | |||
| xhr.open(method, url); | |||
| } else { | |||
| throw new Error('CORS is not supported'); | |||
| throw dev().createExpectedError('CORS is not supported'); | |||
There was a problem hiding this comment.
@dvoytenko can you review this?
erwinmombay
commented
Dec 16, 2016
| }; | ||
| xhr.onabort = () => { | ||
| reject(new Error('Request aborted')); | ||
| reject(user().createExpectedError('Request aborted')); |
There was a problem hiding this comment.
@dvoytenko please review
erwinmombay
force-pushed
the
log-update
branch
from
5ec84cb to
9062274
Compare
dvoytenko
approved these changes
Dec 17, 2016
erwinmombay
force-pushed
the
log-update
branch
from
9062274 to
a4a008e
Compare
erwinmombay
force-pushed
the
log-update
branch
from
a4a008e to
d1f3715
Compare
Lith
pushed a commit
to Lith/amphtml
that referenced
this pull request
Dec 22, 2016
* add expectedError method * add private helper method and tests * add private annotation * add createExpectedError method and fix xhr-impl
Lith
pushed a commit
to Lith/amphtml
that referenced
this pull request
Dec 22, 2016
* add expectedError method * add private helper method and tests * add private annotation * add createExpectedError method and fix xhr-impl
torch2424
pushed a commit
to torch2424/amphtml
that referenced
this pull request
Jan 3, 2017
* add expectedError method * add private helper method and tests * add private annotation * add createExpectedError method and fix xhr-impl
This was referenced Aug 13, 2020
This was referenced Dec 18, 2020
This was referenced Jan 11, 2021
This was referenced Feb 14, 2021
This was referenced Jun 7, 2021
This was referenced Jul 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.