Type-check for <amp-viz-vega> #5008
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erwinmombay
reviewed
Sep 14, 2016
| @@ -186,7 +202,9 @@ export class AmpVizVega extends AMP.BaseElement { | |||
|
|
|||
| return parsePromise.then(chartFactory => { | |||
| return vsyncFor(this.win).mutatePromise(() => { | |||
| dom.removeChildren(this.container_); | |||
| const container = /** @type {!Element} */( | |||
| dev().assert(this.container_)); | |||
There was a problem hiding this comment.
use dev().assertElement instead, then you can get rid of the type cast annotation
There was a problem hiding this comment.
done (also used assertString for the other case)
|
LGTM |
erwinmombay
approved these changes
Sep 16, 2016
mityaha
pushed a commit
to ooyala/amphtml
that referenced
this pull request
Nov 30, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.