eliminate dev().assert() and dev().fine() calls from src/log.js module #4271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erwinmombay
force-pushed
the
eliminate-new-log-calls
branch
2 times, most recently
from
7e4f9cb to
b5f441d
Compare
|
cc @jridgewell just need to add tests |
erwinmombay
force-pushed
the
eliminate-new-log-calls
branch
from
b5f441d to
e5dbf4d
Compare
|
will eventually remove the old |
erwinmombay
force-pushed
the
eliminate-new-log-calls
branch
from
e5dbf4d to
28e9af3
Compare
|
LGTM. I'm going to merge this into my branch. |
erwinmombay
force-pushed
the
eliminate-new-log-calls
branch
2 times, most recently
from
0beed9d to
dd5b16e
Compare
erwinmombay
changed the title
|
tests added @jridgewell let me know when you have your changes pushed to a PR so i can test against it. thanks |
erwinmombay
force-pushed
the
eliminate-new-log-calls
branch
from
dd5b16e to
e4a0f12
Compare
|
I can confirm they DCE correctly. |
|
Closed by #4261. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is in preparation for the changes @jridgewell is doing for us to tree shake the log module better. (remove side effects from a simple module import)