✨ Criteo: Add uid and pid macro to amp endpoint #39723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
powerivq
approved these changes
Jan 8, 2024
|
Hello @vraybaud can you sign the CLA following the link in the above message? It is required before we can merge the PR. |
|
Furthermore, you need to rebase against the latest main branch. It is why the test has failed. |
|
@powerivq Thanks a lot for the very fast review ! I did the rebase. |
|
@vraybaud Please fix |
eszponder
pushed a commit
to krzysztofequativ/amphtml
that referenced
this pull request
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
We are improving our inventory management and will rely on uid and pid query parameters in the future. But we are still needing the old query parameters during the transition.
Please could you review this ?
Thanks !