Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📦 Update build-system devDependencies #39575

Merged
merged 2 commits into from
Oct 20, 2023

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Oct 20, 2023

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
@puppeteer/browsers (source) 1.7.1 -> 1.8.0 age adoption passing confidence
puppeteer-core (source) 21.3.8 -> 21.4.0 age adoption passing confidence

See all other Renovate PRs on the Dependency Dashboard

How to resolve breaking changes

This PR may introduce breaking changes that require manual intervention. In such cases, you will need to check out this branch, fix the cause of the breakage, and commit the fix to ensure a green CI build. To check out and update this PR, follow the steps below:

# Check out the PR branch
git checkout -b renovate/build-system-devdependencies main
git pull https://github.com/ampproject/amphtml.git renovate/build-system-devdependencies

# Directly make fixes and commit them
amp lint --fix # For lint errors in JS files
amp prettify --fix # For prettier errors in non-JS files
# Edit source code in case of new compiler warnings / errors

# Push the changes to the branch
git push git@github.com:ampproject/amphtml.git renovate/build-system-devdependencies:renovate/build-system-devdependencies

Release Notes

puppeteer/puppeteer (@​puppeteer/browsers)

v1.8.0

Compare Source

Big Changes

API Changes

Changed:
  • PUPPETEER_CHROMIUM_REVISION and PUPPETEER_EXECUTABLE_PATH environment variables will now not only affect puppeteer installation but your scripts as well. (28d9211)
  • page.goto now accepts a referer argument. (cbce839)
Added:

Bug Fixes

  • #​317 - Response improvements
  • #​846 - How to catch a "Permission request" dialog event?
  • #​1077 - Support for geolocation mock?
  • #​1159 - ignoreHTTPSErrors is not working when request interception is on
  • #​2171 - Can I get Remote Address with puppteer?
  • #​2764 - Some URLs sequence makes next responses to be null
  • #​2925 - puppeteer@next is not autoupdated
  • #​3090 - Referrer should be parameter, not extra header
  • #​3106 - Calling a exposed function inside an evaluateOnNewDocument function does not work on Chrome 70

Raw Notes

42fde9b - chore: another attempt to fix pptr@next (#​3210)
b7e922b - chore: fix puppeteer@next race condition (#​3209)
f230722 - refactor: avoid dynamic requires in lib/ folder (#​3208)
d54c7ed - fix(page): Page.goto should properly handle historyAPI in beforeunload (#​3198)
28d9211 - feat(puppeteer): support convenience env variables (#​3190)
7f9e276 - feat(network): introduce Response.statusText() (#​3193)
84c2621 - refactor(network): Create Request class right away from payload (#​3194)
7db4f0f - chore: preserve links to master version of API from README.md (#​3197)
3364659 - docs(api.md): Added cutoff values for scale option in page.pdf function (#​3201)
e07567f - docs(api.md): fix a typo (#​3196)
1ba2b85 - feat(network): introduce Response.remoteAddress() (#​3192)
52cf16c - refactor(network): Create Response class right away from payload (#​3191)
22c0ce6 - test: cleanup newly added test for navigation referer (#​3179)
2de5a42 - docs(api.md): expand on puppeteer-core vs puppeteer (#​3189)
93f267b - docs(api.md): re-factor api.md heading (#​3185)
cbce839 - docs(api.md): small typo (#​3188)
32c0363 - feat(chromium): roll Chromium to r588429 (#​3181)
464f3b4 - feat(page): Add 'referer' as a parameter to Page.goto() (#​3128)
1702928 - feat(page): Introduce page.setGeolocation method (#​3160)
1000997 - docs(api.md): page.hover typo (#​3165)
50d6c2d - feat(browsercontext): implement BrowserContext.overridePermissions (#​3159)
df459ba - feat(chromium): roll Chromium to r587164 (#​3153)
bfed64f - docs(readme.md): change Megabits to Megabytes.
3d7ae2a - fix: fix null-type bugs (#​3137)
d1105af - Revert "Add Puppeteer Recorder extension to docs" (#​3102)
ce64ae2 - test: add test for request interception with 302 after POST (#​3105)
d6eb3b4 - refactor: drop object factory from execution context (#​3099)
73c43be - docs: Add Puppeteer Recorder extension to docs (#​3088)
395c506 - docs(troubleshooting): add libatk-bridge2.0-0 to ubuntu dependencies (#​3096)
ce78327 - feat(chromium): roll Chromium to r583214 (#​3092)
b8e0d62 - docs(readme): refer to awesome-puppeteer (#​3062)
3ae85e4 - docs: mention puppeteer-core (#​3061)
af361c8 - chore: bump version to v1.7.0-post (#​3060)


Configuration

📅 Schedule: Branch creation - "after 12am every weekday" in timezone America/Los_Angeles, Automerge - At any time (no schedule defined).

🚦 Automerge: Enabled.

Rebasing: Never, or you tick the rebase/retry checkbox.

👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot added the WG: infra label Oct 20, 2023
@renovate renovate bot enabled auto-merge (squash) October 20, 2023 13:53
@amp-owners-bot
Copy link

amp-owners-bot bot commented Oct 20, 2023

Hey @danielrozenberg! These files were changed:

build-system/tasks/visual-diff/browser.js
build-system/tasks/visual-diff/package-lock.json
build-system/tasks/visual-diff/package.json

@renovate renovate bot merged commit 7d41974 into main Oct 20, 2023
@renovate renovate bot deleted the renovate/build-system-devdependencies branch October 20, 2023 18:15
@ampprojectbot
Copy link
Member

Warning: disparity between this PR Percy build and its main build

The Percy build for this PR was approved (either manually by a member of the AMP team, or automatically if there were no visual diffs). However, during a continuous integration step we generated another Percy build using the commit on the main branch that this PR was merged into, and there appears to be a mismatch between the two.

This is possibly an indication of an issue with this pull request, but could also be the result of flakiness. Please inspect the two builds < This PR's Percy build / main commit's Percy build > and determine further action:

  • If the disparity appears to be caused by this PR, please create an bug report or send out a new PR to fix
  • If the disparity appears to be a flake, please @-mention ampproject/wg-approvers in a comment
  • If there is no disparity and this comment was created by mistake, please @-mention ampproject/wg-infra
  • If unsure, @-mention ampproject/wg-approvers

eszponder pushed a commit to krzysztofequativ/amphtml that referenced this pull request Apr 22, 2024
* 📦 Update build-system devDependencies

* Replace visual-diff browser from Chromium to Chrome and update to v115

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Daniel Rozenberg <rodaniel@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants