Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ ENHANCE: expand widgetOpts/logOpts #39442

Merged
merged 1 commit into from
Sep 11, 2023
Merged

Conversation

powerivq
Copy link
Contributor

@powerivq powerivq commented Sep 7, 2023

Add new option for special case
Add backup options to deliver accurate data

The original PR won't trigger the build on Circle. #39433

@Minjiicho
Copy link

Thank you for help @powerivq
Is there anything that I need to do for next step?

@powerivq powerivq merged commit ae6e912 into ampproject:main Sep 11, 2023
@powerivq powerivq deleted the widget branch September 11, 2023 19:48
@ampprojectbot
Copy link
Member

Warning: disparity between this PR Percy build and its main build

The Percy build for this PR was approved (either manually by a member of the AMP team, or automatically if there were no visual diffs). However, during a continuous integration step we generated another Percy build using the commit on the main branch that this PR was merged into, and there appears to be a mismatch between the two.

This is possibly an indication of an issue with this pull request, but could also be the result of flakiness. Please inspect the two builds < This PR's Percy build / main commit's Percy build > and determine further action:

  • If the disparity appears to be caused by this PR, please create an bug report or send out a new PR to fix
  • If the disparity appears to be a flake, please @-mention ampproject/wg-approvers in a comment
  • If there is no disparity and this comment was created by mistake, please @-mention ampproject/wg-infra
  • If unsure, @-mention ampproject/wg-approvers

@Minjiicho
Copy link

Minjiicho commented Sep 12, 2023

@powerivq There seems certain error 😢 Could you please figure it out?
We hope it can be fixed and released normally 🙏

@powerivq
Copy link
Contributor Author

This error can be ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants