✨ ENHANCE: expand Dable AMP options #39413
Conversation
Minjiicho
commented
Aug 28, 2023
Minjiicho
commented
- Add new option for special case
- Add backup options to deliver accurate data
|
|
Minjiicho
force-pushed
the
feature/add_logopts
branch
from
7bee2f5 to
5b24924
Compare
|
Hi @calebcordry |
erwinmombay
requested review from
powerivq and
erwinmombay
and removed request for
calebcordry
| @@ -52,6 +56,10 @@ export function dable(global, data) { | |||
| widgetOpts.category3 = articleSection3; | |||
| logOpts.category3 = articleSection3; | |||
| } | |||
| if (orgServiceId) { | |||
| widgetOpts.orgServiceId = orgServiceId; | |||
There was a problem hiding this comment.
@powerivq these don't get obfuscated?
There was a problem hiding this comment.
I think it's up to Dable whether to do something about these parameters.
There was a problem hiding this comment.
@erwinmombay Thank you for the review 🙏
It's an internally agreed value, so I don't think it'll be a problem but please let me know if you have any concerns.
| @@ -52,6 +56,10 @@ export function dable(global, data) { | |||
| widgetOpts.category3 = articleSection3; | |||
| logOpts.category3 = articleSection3; | |||
| } | |||
| if (orgServiceId) { | |||
| widgetOpts.orgServiceId = orgServiceId; | |||
There was a problem hiding this comment.
I think it's up to Dable whether to do something about these parameters.
|
For some reasons, circle build is not running. Can you rebase so that it can retry? @Minjiicho |
@powerivq I made trivial update to the guide. Hope CircleCI rerun 🙏 |
|
@powerivq CircleCI is still on waiting 🤔 |
|
@Minjiicho I suspect it is because the branch name contains |
@powerivq Thx for sharing suspicious part. Let me close this PR since reopened new PR #39433 |
