Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change amp-story-subscriptions attribute names to reflect their flexibility #38176

Merged
merged 1 commit into from
May 10, 2022
Merged

Change amp-story-subscriptions attribute names to reflect their flexibility #38176

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions examples/amp-story/amp-story-subscriptions.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,9 +229,9 @@ <h3>Cultral Experiences</h3>

<amp-story-subscriptions layout='container'
price='$0.50/week'
title='Information at your fingertips'
subtitle-first='Subscribe for unlimited access.'
subtitle-second='Cancel anytime.'>
headline='Information at your fingertips'
description='Subscribe for unlimited access.'
additional-description='Cancel anytime.'>
</amp-story-subscriptions>
</amp-story>>
</body>
Expand Down
6 changes: 3 additions & 3 deletions examples/visual-tests/amp-story/amp-story-subscriptions.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,9 +219,9 @@ <h3>Cultral Experiences</h3>

<amp-story-subscriptions layout='container'
price='$0.50/week'
title='Information at your fingertips'
subtitle-first='Subscribe for unlimited access.'
subtitle-second='Cancel anytime.' publisher-button-text='Subscribe'>
headline='Information at your fingertips'
description='Subscribe for unlimited access.'
additional-description='Cancel anytime.'>
</amp-story-subscriptions>
</amp-story>>
</body>
Expand Down
4 changes: 2 additions & 2 deletions extensions/amp-story-subscriptions/0.1/amp-story-subscriptions.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,7 @@ iframe.swg-dialog {
margin-bottom: 0.2em !important;
}

.i-amphtml-story-subscriptions-title {
.i-amphtml-story-subscriptions-headline {
display: block !important;
font-weight: 700 !important;
font-size: 1.15em !important;
Expand All @@ -152,7 +152,7 @@ iframe.swg-dialog {
margin: 0.4em 0 0.15em !important;
}

.i-amphtml-story-subscriptions-subtitle-first, .i-amphtml-story-subscriptions-subtitle-second {
.i-amphtml-story-subscriptions-description, .i-amphtml-story-subscriptions-additional-description {
display: block !important;
font-size: 0.9em !important;
letter-spacing: -0.015em !important;
Expand Down
16 changes: 8 additions & 8 deletions extensions/amp-story-subscriptions/0.1/amp-story-subscriptions.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,17 +222,17 @@ export class AmpStorySubscriptions extends AMP.BaseElement {
<span class="i-amphtml-story-subscriptions-price">
{this.element.getAttribute('price')}
</span>
{this.element.getAttribute('title') && (
<span class="i-amphtml-story-subscriptions-title">
{this.element.getAttribute('title')}
{this.element.getAttribute('headline') && (
<span class="i-amphtml-story-subscriptions-headline">
{this.element.getAttribute('headline')}
</span>
)}
<span class="i-amphtml-story-subscriptions-subtitle-first">
{this.element.getAttribute('subtitle-first')}
<span class="i-amphtml-story-subscriptions-description">
{this.element.getAttribute('description')}
</span>
{this.element.getAttribute('subtitle-second') && (
<span class="i-amphtml-story-subscriptions-subtitle-second">
{this.element.getAttribute('subtitle-second')}
{this.element.getAttribute('additional-description') && (
<span class="i-amphtml-story-subscriptions-additional-description">
{this.element.getAttribute('additional-description')}
</span>
)}
<button
Expand Down