New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added some vars and requests in gfksensic.json #37722

Merged

alanorozco merged 10 commits into ampproject:main from dimitarandonov:vendor/gfk-sensic

May 2, 2022

Contributor

dimitarandonov commented Feb 17, 2022

No description provided.


          added some vars and requests in gfksensic.json

2d43ef5

amp-owners-bot bot requested a review from alanorozco

February 17, 2022 12:49

CLAassistant commented Feb 17, 2022 •

edited

Loading

All committers have signed the CLA.

dimitarandonov added 9 commits

February 17, 2022 15:46


          fixed tests

92895b4


          added some requests for testing or ignoring test in vendor-requests.json

fbf4a7b


          fixed requests

5dfcad1


          0.1.1

d2ce0c0


          rollback project version and package-lock

da5d97b


          fixed expected value in vendor-request

6e326a5


          fixed expected value in vendor-request

2601f76


          added new variables and triggers in gfk's example

4e1b34d


          rerun tests

6c51e0b

Contributor Author

dimitarandonov commented Mar 9, 2022

Hi, I hope someone is able to look at this PR soon. We would like to get this merged as soon as possible. Any feedback is appreciated.

Contributor Author

dimitarandonov commented Mar 14, 2022

Hi, we are currently blocking some of our clients. Can you give some feedback if everything is ok or not with this pull request? We would like to get this merged as soon as possible.

Contributor Author

dimitarandonov commented Mar 18, 2022

Hi @alanorozco,

We need to have this as soon as possible to enable our clients to use the AMP integration properly.

Can you please let us know if we missed anything to get this PR reviewed?

Contributor Author

dimitarandonov commented Mar 25, 2022

Hi @alanorozco ,

We need to have this as soon as possible to enable our clients to use the AMP integration properly.

Can you please let us know if we missed anything to get this PR reviewed?

4 similar comments

Contributor Author

dimitarandonov commented Mar 31, 2022

Hi @alanorozco ,

We need to have this as soon as possible to enable our clients to use the AMP integration properly.

Can you please let us know if we missed anything to get this PR reviewed?

Contributor Author

dimitarandonov commented Apr 1, 2022

Hi @alanorozco ,

We need to have this as soon as possible to enable our clients to use the AMP integration properly.

Can you please let us know if we missed anything to get this PR reviewed?

Contributor Author

dimitarandonov commented Apr 8, 2022

Hi @alanorozco ,

We need to have this as soon as possible to enable our clients to use the AMP integration properly.

Can you please let us know if we missed anything to get this PR reviewed?

Contributor Author

dimitarandonov commented Apr 13, 2022

Hi @alanorozco ,

We need to have this as soon as possible to enable our clients to use the AMP integration properly.

Can you please let us know if we missed anything to get this PR reviewed?

martinbruntsch commented May 2, 2022

Hi @powerivq @processprocess @alanorozco, @dmanek, @caroqliu , @rbeckthomas . we are waiting for review and we are totally puzzeled since nothing happens for 2 month now. What are we doing wrong? anything missing?
Thanks for your feedback. Appreciate your help.
Cheers

alanorozco approved these changes

View reviewed changes

Member

alanorozco left a comment

Thank you for your PR and your patience. Approved.

alanorozco merged commit edf71ba into ampproject:main

ampprojectbot added PR use: In Beta / Experimental PR use: In Stable labels

westonruter added a commit that referenced this pull request


          Merge branch 'main' of github.com:ampproject/amphtml into add/amp-meg…

e116f69

…a-menu-images-validator-spec

* 'main' of github.com:ampproject/amphtml: (90 commits)
  🔥 [Story mediapool] Fix videos from mediapool with `noaudio` don't have audio when reused. (#38216)
  Hide progress bar on the control group of auto advance experiment (#38215)
  ✨ Add Bento Autocomplete Component (#37837)
  🌐 [Story subscription] Subscription localization async (#38204)
  Dable: add new optional parameter "channel" (#38199)
  ✨ [AMP Story Paywall] Enable developers to specify a custom subscriptions page index (#38175)
  SwG Release 0.1.22.217 (#38187)
  amp-script: implements new size limits for sandboxed scripts (#38185)
  🖍  Hide the system layer and progress bar in preview mode (#38163)
  added minItems (#38177)
  Prevent expandTemplate from ReDOSing (#38178)
  Change amp-story-subscriptions attribute name to reflect its flexibility (#38176)
  🐛 [Story Preview] Enable amp-video to play in preview mode (#38149)
  Added the possibility to get page count to story messaging api (#38170)
  SwG Release 0.1.22.216 (#38168)
  Allow @newmuis to update OWNERS files (#38169)
  ✨ Add Richaudience to RTC callout vendors (#38160)
  🚀  SunMedia: Update amp-ad (#38128)
  Remove option to deploy PR artifacts to a static website (#38152)
  added some vars and requests in gfksensic.json (#37722)
  ...

ampprojectbot added the PR use: In LTS label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR use: In Beta / Experimental PR use: In LTS PR use: In Stable