Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📖 BentoBaseCarousel README code fixes #35973

Merged
merged 1 commit into from
Sep 7, 2021
Merged

📖 BentoBaseCarousel README code fixes #35973

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 11 additions & 11 deletions extensions/amp-base-carousel/1.0/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,9 +83,9 @@ import '@ampproject/bento-base-carousel';
<div class="green-gradient"></div>
</bento-base-carousel>
<div class="buttons" style="margin-top: 8px;">
<button id='prev-button'>Go to previous slide</button>
<button id='next-button'>Go to next slide</button>
<button id='go-to-button'>Go to slide with green gradient</button>
<button id="prev-button">Go to previous slide</button>
<button id="next-button">Go to next slide</button>
<button id="go-to-button">Go to slide with green gradient</button>
</div>

<script>
Expand Down Expand Up @@ -403,7 +403,7 @@ npm install @ampproject/bento-base-carousel

```javascript
import React from 'react';
import { BaseCarousel } from '@ampproject/bento-base-carousel/react';
import {BaseCarousel} from '@ampproject/bento-base-carousel/react';
import '@ampproject/bento-base-carousel/styles.css';

function App() {
Expand Down Expand Up @@ -498,7 +498,7 @@ The `BentoBaseCarousel` component has a defined layout size type. To ensure the
Or via `className`:

```jsx
<BaseCarousel className='custom-styles'>
<BaseCarousel className="custom-styles">
<img src="puppies.jpg" />
<img src="kittens.jpg" />
<img src="hamsters.jpg" />
Expand Down Expand Up @@ -570,7 +570,7 @@ const count = window.matchMedia('(max-width: 600px)').matches ? 4 : 3;
>
<img style={{height: '100%', width: '100%'}} src="…" />
…
</bento-base-carousel>
</BentoBaseCarousel>
```

#### Props
Expand Down Expand Up @@ -691,19 +691,19 @@ Arrow buttons can be customized by passing in your own custom markup. For exampl
}
```

```html
```jsx
function CustomPrevButton(props) {
return <button {...props} className='carousel-prev'>
return <button {...props} className="carousel-prev" />
}

function CustomNextButton(props) {
return <button {...props} className='carousel-prev'>
return <button {...props} className="carousel-prev" />
}

<BentoBaseCarousel
arrowPrevAs={CustomPrevButton}
arrowNextAs={CustomNextButton>
arrowNextAs={CustomNextButton}>
<div>first slide</div>
…
// …
</BentoBaseCarousel>
```