Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ remove MessageType re-export and update MessageType imports #35817

Merged
merged 1 commit into from
Aug 26, 2021
Merged

♻️ remove MessageType re-export and update MessageType imports #35817

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions extensions/amp-embedly-card/1.0/component.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
import {deserializeMessage} from '#core/3p-frame-messaging';
import {MessageType, deserializeMessage} from '#core/3p-frame-messaging';

import * as Preact from '#preact';
import {useCallback, useContext, useState} from '#preact';
import {forwardRef} from '#preact/compat';
import {MessageType, ProxyIframeEmbed} from '#preact/component/3p-frame';
import {ProxyIframeEmbed} from '#preact/component/3p-frame';

import {EmbedlyContext} from './embedly-context';

Expand Down
4 changes: 2 additions & 2 deletions extensions/amp-facebook/1.0/component.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import * as Preact from '#preact';
import {MessageType, ProxyIframeEmbed} from '#preact/component/3p-frame';
import {ProxyIframeEmbed} from '#preact/component/3p-frame';
import {dashToUnderline} from '#core/types/string';
import {deserializeMessage} from '#core/3p-frame-messaging';
import {MessageType, deserializeMessage} from '#core/3p-frame-messaging';
import {forwardRef} from '#preact/compat';
import {tryParseJson} from '#core/types/object/json';
import {useCallback, useLayoutEffect, useMemo, useState} from '#preact';
Expand Down
2 changes: 1 addition & 1 deletion extensions/amp-iframe/1.0/component.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import * as Preact from '#preact';
import {useCallback, useEffect, useRef} from '#preact';
import {MessageType} from '#preact/component/3p-frame';
import {MessageType} from '#core/3p-frame-messaging';
import {toWin} from '#core/window';

const NOOP = () => {};
Expand Down
5 changes: 2 additions & 3 deletions extensions/amp-twitter/1.0/component.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
import * as Preact from '#preact';
import {MessageType, ProxyIframeEmbed} from '#preact/component/3p-frame';

import {deserializeMessage} from '#core/3p-frame-messaging';
import {ProxyIframeEmbed} from '#preact/component/3p-frame';
import {MessageType, deserializeMessage} from '#core/3p-frame-messaging';
import {forwardRef} from '#preact/compat';
import {useCallback, useMemo, useState} from '#preact';

Expand Down
4 changes: 0 additions & 4 deletions src/preact/component/3p-frame.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import {getOptionalSandboxFlags, getRequiredSandboxFlags} from '#core/3p-frame';
import {MessageType} from '#core/3p-frame-messaging';
import {sequentialIdGenerator} from '#core/data-structures/id-generator';
import {dict} from '#core/types/object';
import {includes} from '#core/types/string';
Expand Down Expand Up @@ -27,9 +26,6 @@ import {parseUrlDeprecated} from '../../url';
/** @type {!Object<string,function():void>} 3p frames for that type. */
export const countGenerators = {};

/** re-exports variable to preserve compat with components that already import this */
export {MessageType};

// Block synchronous XHR in ad. These are very rare, but super bad for UX
// as they block the UI thread for the arbitrary amount of time until the
// request completes.
Expand Down