Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bento: Prepare amp-video file structure for npm publishing #34822

Merged
merged 7 commits into from
Jun 11, 2021
Merged

Bento: Prepare amp-video file structure for npm publishing #34822

merged 7 commits into from
Jun 11, 2021

Conversation

caroqliu
Copy link
Contributor

@caroqliu caroqliu commented Jun 10, 2021 •
edited
Loading

Tracker Issue: #34137

@caroqliu caroqliu mentioned this pull request Jun 10, 2021
Closed
12 tasks
rcebulko
rcebulko approved these changes Jun 10, 2021
View reviewed changes
Copy link
Contributor

@rcebulko rcebulko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

alanorozco
alanorozco approved these changes Jun 10, 2021
View reviewed changes
Copy link
Member

@alanorozco alanorozco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@caroqliu caroqliu merged commit 22cb782 into ampproject:main Jun 11, 2021
@estherkim
Copy link
Collaborator

Hii if you want this to be published automatically, "npm": true needs to be set here https://github.com/ampproject/amphtml/blob/main/build-system/compile/bundles.config.extensions.json#L1090-L1097

@caroqliu
Copy link
Contributor Author

Hii if you want this to be published automatically, "npm": true needs to be set here https://github.com/ampproject/amphtml/blob/main/build-system/compile/bundles.config.extensions.json#L1090-L1097

🤦 Good catch, missed the one important bit we needed. I'll rename this PR to reflect what actually happened.

@caroqliu caroqliu changed the title Bento: Enable npm for amp-video Bento: Prepare for amp-video file structure for npm publishing Jun 11, 2021
@caroqliu caroqliu changed the title Bento: Prepare for amp-video file structure for npm publishing Bento: Prepare amp-video file structure for npm publishing Jun 11, 2021
westonruter added a commit to westonruter/amphtml that referenced this pull request Jun 11, 2021
@westonruter
Merge branch 'main' of github.com:ampproject/amphtml into add/amp-fac…
4870eef 
…ebook-like-bento-version

* 'main' of github.com:ampproject/amphtml:
  minor updates + fix broken links (ampproject#34840)
  Add "wrapper": "bento" option to Bento components (ampproject#34838)
  ♻️ Move src/layout into core to unblock buildDOM for amp-layout (ampproject#34818)
  ♿ Apply `lang="en"` to relevant snippets in `test/` (ampproject#34768)
  Bento: Enable `npm` for `amp-video` (ampproject#34822)
  ✨[story-ads] Introduce new yellow segment progress bar v2 (ampproject#34804)
  SwG Release (ampproject#34825)
  📦 Update build-system devDependencies to v7.14.5 (ampproject#34802)
  Disable viewport warnings in experiment. (ampproject#34809)
  Apply lang="en" to examples/ (ampproject#34759)
  ✨ [Amp story] Scaffold desktop one panel experiment (ampproject#34755)
  ♻️ Migrate Style and DOM helpers into core/DOM + type-checking (ampproject#34681)
  🏗 Don't pull all externs into experiments (ampproject#34800)
  typechecking: remove pride as not compatible with rest of strategy (ampproject#34787)
  Fix forbidden terms to unblock `main` (ampproject#34799)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alanorozco alanorozco alanorozco approved these changes

@rcebulko rcebulko rcebulko approved these changes

@jridgewell jridgewell Awaiting requested review from jridgewell

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@caroqliu @estherkim @alanorozco @rcebulko