-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
♿ Apply lang="en"
to relevant snippets in extensions/
#34766
Conversation
Hey @ampproject/wg-caching! These files were changed:
Hey @gmajoulet! These files were changed:
Hey @processprocess! These files were changed:
Hey @t0mg! These files were changed:
Hey @mszylkowski! These files were changed:
Hey @newmuis! These files were changed:
|
I'm not opposed, but these are all test files for validator, not examples. They aren't documentation (tests are partially documentation, but not in the way this is being applied). You've already made the changes, so go ahead, but I would recommend saving the trouble in future cases of this. |
Thanks for the recommendation—I tend to agree and will keep an eye out for similar changes in the future that may not be worth the trouble. |
This PR is a partial copy of #31208, which adds
lang="en"
to relevant code snippets in this codebase. Instead of copying the PR file-for-file, I decided to break this change up into a few root directories for ease of review and less likelihood of falling behind to merge conflicts. /to @banaag who approved the original PROriginal PR description:
Others in the series: #34757 #34758 #34759
/cc @TetraLogicalHelpdesk