Async pause: simplify adoption with a helper #33368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @alanorozco! These files were changed: |
dvoytenko
force-pushed
the
run3/pause-helper
branch
from
294b51b to
9e7843b
Compare
jridgewell
approved these changes
Mar 18, 2021
samouri
approved these changes
Mar 19, 2021
dvoytenko
force-pushed
the
run3/pause-helper
branch
from
1012fb9 to
2f52bf7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think a simple helper would simplify the support for us. Instead of having several state vars we'd just encapsulate them inside a single helper.
Partial for #31915.
Partial for #31540.