Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ Update mixed imports of assertions to use standalone helpers #33036

Closed
wants to merge 14 commits into from

Conversation

rcebulko
Copy link
Contributor

@rcebulko rcebulko commented Mar 3, 2021

Building on #32788 and companion to #32828
Migrating all uses gradually; once ties to assertions fromlog.js have been severed, will remove the log.js versions and remove the pure prefix

@rcebulko rcebulko force-pushed the assert-mixed-imports branch from 7fbbdb0 to b68c946 Compare March 3, 2021 16:59
@lgtm-com
Copy link

lgtm-com bot commented Mar 3, 2021

This pull request introduces 1 alert when merging b68c946 into c8f2b52 - view on LGTM.com

new alerts:

  • 1 for Syntax error

@rcebulko rcebulko force-pushed the assert-mixed-imports branch from dca96ce to 816138b Compare March 3, 2021 21:16
@rcebulko rcebulko force-pushed the assert-mixed-imports branch from 80c54cc to a1f5f13 Compare March 4, 2021 15:40
@rcebulko rcebulko closed this Apr 12, 2021
@rcebulko rcebulko deleted the assert-mixed-imports branch April 12, 2021 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant