feature(amp-live-list): add update feature #3260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erwinmombay
force-pushed
the
amp-live-list-replace
branch
5 times, most recently
from
edb315f to
16fffd2
Compare
|
@cramforce PTAL |
|
@cramforce ping |
erwinmombay
force-pushed
the
amp-live-list-replace
branch
from
16fffd2 to
1b166ac
Compare
| var doctype = '<!doctype html>\n'; | ||
| res.setHeader('Content-Type', 'text/html'); | ||
| res.statusCode = 200; | ||
| if (ctr != 0) { |
There was a problem hiding this comment.
Should this be throttled a bit and sometimes return nothing?
There was a problem hiding this comment.
good point, will add variation here and on upcoming full sample
|
LGTM |
erwinmombay
force-pushed
the
amp-live-list-replace
branch
5 times, most recently
from
d5fb936 to
baf5abc
Compare
erwinmombay
force-pushed
the
amp-live-list-replace
branch
from
baf5abc to
0e5ebe1
Compare
1 task
This was referenced Dec 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.