Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove internal CE API usage from tests #32353

Merged
merged 4 commits into from
Feb 2, 2021

Conversation

dvoytenko
Copy link
Contributor

Partial for #31915.

This only affects tests. No code changes. Most of changes are replacing x.implementation_ with await x.getImpl().

However, there's an important purpose for this change: the tests no longer rely here on the implementation being immediately available when a DOM element is created. This is a big downpayment for the remainder of the refactoring.

@dvoytenko dvoytenko marked this pull request as ready for review February 2, 2021 20:26
@amp-owners-bot
Copy link

amp-owners-bot bot commented Feb 2, 2021

Hey @alanorozco! These files were changed:

extensions/amp-3q-player/0.1/test/test-amp-3q-player.js
extensions/amp-brid-player/0.1/test/test-amp-brid-player.js
extensions/amp-connatix-player/0.1/test/test-amp-connatix-player.js
extensions/amp-delight-player/0.1/test/test-amp-delight-player.js
extensions/amp-nexxtv-player/0.1/test/test-amp-nexxtv-player.js
extensions/amp-o2-player/0.1/test/test-amp-o2-player.js
extensions/amp-powr-player/0.1/test/test-amp-powr-player.js
extensions/amp-viqeo-player/0.1/test/test-amp-viqeo-player.js

Hey @gmajoulet, @newmuis, @Enriqe! These files were changed:

extensions/amp-story/1.0/test/test-amp-story.js

Copy link
Member

@samouri samouri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so many lines!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants