🚀 Remove NoInline compiler usages
#31837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… of try catch blocks
kristoferbaxter
changed the title
NoInline compiler ruleNoInline compiler usages
samouri
approved these changes
Jan 7, 2021
rsimha
approved these changes
Jan 7, 2021
| @@ -104,13 +104,9 @@ function compileCss(options = {}) { | |||
| */ | |||
| function writeCss(css, jsFilename, cssFilename, append) { | |||
| return toPromise( | |||
| file( | |||
| jsFilename, | |||
| '/** @noinline */ export const cssText = ' + JSON.stringify(css), | |||
There was a problem hiding this comment.
Nice to see the removal of the hack added by #23373.
jridgewell
approved these changes
Jan 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #4104.
This PR removes the NoInline compiler rule since V8 has since fixed the performance of code within try/catch blocks. Bonus, this means the codebase is a bit smaller when shipped over the wire.