Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

collectVars API in url replacements #3178

Merged
merged 2 commits into from
May 10, 2016
Merged

collectVars API in url replacements #3178

merged 2 commits into from
May 10, 2016

Conversation

dvoytenko
Copy link
Contributor

Partial for #2970.

erwinmombay
erwinmombay reviewed May 10, 2016
View reviewed changes
src/service/url-replacements-impl.js
* @return {!Promise<!Object<string, *>>}
*/
collectVars(url, opt_bindings) {
const vars = {};
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Object.create

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@erwinmombay
Copy link
Member

@dvoytenko LGTM, with 1 request

@dvoytenko dvoytenko merged commit 2afa6d2 into ampproject:master May 10, 2016
@dvoytenko dvoytenko deleted the server-access2-collectvars branch May 10, 2016 23:30
@dvoytenko dvoytenko mentioned this pull request May 11, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@erwinmombay erwinmombay

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dvoytenko @erwinmombay