Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rubicon Adapter updates #3159

Merged
merged 1 commit into from
May 9, 2016
Merged

Rubicon Adapter updates #3159

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion ads/rubicon.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,8 @@ export function rubicon(global, data) {
checkData(data, [
'slot', 'targeting', 'categoryExclusions',
'tagForChildDirectedTreatment', 'cookieOptions',
'overrideWidth', 'overrideHeight',
'overrideWidth', 'overrideHeight', 'loadingStrategy',
'consentNotificationId', 'useSameDomainRenderingUntilDeprecated',
'account', 'site', 'zone', 'size',
'pos', 'kw', 'visitor', 'inventory',
'type', 'method', 'callback',
Expand Down Expand Up @@ -101,6 +102,7 @@ function fastLane(global, data) {
if (data.visitor) { setFPD('V', data.visitor); };
if (data.inventory) { setFPD('I', data.inventory); };
rubicontag.setUrl(getSourceUrl(context.location.href));
rubicontag.setIntegration('amp');
rubicontag.run(gptrun, 1000);

});
Expand All @@ -122,6 +124,7 @@ function smartTag(global, data) {
global.rp_kw = data.kw;
global.rp_visitor = data.visitor;
global.rp_inventory = data.inventory;
global.rp_amp = 'st';
global.rp_callback = data.callback;
/* eslint-enable */
writeScript(global, 'https://ads.rubiconproject.com/ad/' + encodeURIComponent(data.account) + '.js');
Expand Down
6 changes: 4 additions & 2 deletions ads/rubicon.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,10 +108,12 @@ By default the ad size is based on the `width` and `height` attributes of the `a

Supported via `json` attribute (DFP parameters):

- `targeting`
- `categoryExclusions`
- `cookieOptions`
- `tagForChildDirectedTreatment`
- `targeting`
- `cookieOptions`

For the most up-to-date list of Doubleclick supported parameters and usage please refer to Doubleclick reference guide [here](google/doubleclick.md).

##### First Party Data & Keywords
- `data-kw`
Expand Down