Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Consent Metadata macros in ads RTC and amp-analytics #30152

Merged
merged 5 commits into from
Oct 16, 2020
Merged

✨ Consent Metadata macros in ads RTC and amp-analytics #30152

merged 5 commits into from
Oct 16, 2020

Conversation

micajuine-ho
Copy link
Contributor

For #30006

@google-cla google-cla bot added the cla: yes label Sep 8, 2020
@micajuine-ho micajuine-ho changed the title [WIP] ✨ Consent Metadata macros in ads RTC and amp-analytics ✨ Consent Metadata macros in ads RTC and amp-analytics Sep 9, 2020
@micajuine-ho micajuine-ho requested a review from zhouyx September 9, 2020 19:59
zhouyx
zhouyx reviewed Sep 11, 2020
View reviewed changes
zhouyx
zhouyx approved these changes Sep 14, 2020
View reviewed changes
Copy link
Contributor

@zhouyx zhouyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

extensions/amp-analytics/0.1/test/test-variables.js Outdated
);

return check(
'CONSENT_METADATA(gdprApplies)&CONSENT_METADATA(additionalConsent)&CONSENT_METADATA(consentStringType)',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

worth adding a CONSENT_METADATA(invalid_key), and check that it resolves to null.

@micajuine-ho micajuine-ho force-pushed the consent_macro branch 2 times, most recently from 2b1d2ea to b2169cc Compare September 16, 2020 16:34
@CLAassistant
Copy link

CLAassistant commented Oct 8, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@micajuine-ho micajuine-ho reopened this Oct 15, 2020
@micajuine-ho micajuine-ho merged commit 3c0276c into ampproject:master Oct 16, 2020
@micajuine-ho micajuine-ho mentioned this pull request Oct 19, 2020
Closed
@micajuine-ho micajuine-ho mentioned this pull request Nov 13, 2020
Closed
ed-bird pushed a commit to ed-bird/amphtml that referenced this pull request Dec 10, 2020
@ed-bird
✨ Consent Metadata macros in ads RTC and amp-analytics (ampproject#30152
ddf06de 
)

* analytics & ads macro

* Tests and examples

* Suggested changes

* Moving e2e url to fixture
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhouyx zhouyx zhouyx approved these changes

@lannka lannka lannka approved these changes

@rsimha rsimha rsimha approved these changes

Assignees
No one assigned
Labels
cla: yes PR use: In Beta / Experimental
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@micajuine-ho @CLAassistant @zhouyx @lannka @rsimha @ampprojectbot