-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
amp-ad type weborama-display #2833
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
I signed it! I've signed as an employee of the company Weborama. PS: I used the same mail address that I used for my commits, but this is a different address from the one that I use for this Github account. PS2: The travis CI build already failed before my additions. |
@@ -117,6 +121,9 @@ export const adPreconnect = { | |||
webediads: [ | |||
'https://eu1.wbdds.com', | |||
], | |||
'weborama-display': [ | |||
'https://cstatic.weborama.fr', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need to repeat host names used in prefetch
Looks good. 2 small comments. |
For the CLA: Did you submit a corporate or individual CLA? |
About the CLA: It was a coorporate request. |
@bob-v-t Great. The corporate CLAs can take a few business days to process. Personal is instant. |
8d3c33e
to
17aa1fc
Compare
17aa1fc
to
141afd6
Compare
@cramforce I rebased and added the email and phone of our support this morning. I also just signed the CLA again, since the previous one was rejected. Let's hope this one works out 👍 |
Thanks @cramforce! |
Hi guys,
I hereby submit the pull request mentioned in issue number #2832. (backup link)
Please let me know if there is anything I can do to smoothen the integration process!
Thanks,
Bob