🖍 Cleanup several unresolved amp-layout CSS states

[jridgewell]

• Adds unresolved layout for intrinsic styles
• Fixes specificity for unresolved fixed-height styles
• Adds unresolved implicit layout responsive styles

[dreamofabear]

I realized this also doesn't account for implicit container layout. Is there even a CSS selector that would match?

[jridgewell]

What defines implicit container? Is it just a lack of width and height and layout?

[dreamofabear]

amphtml/src/layout.js

Lines 429 to 442 in 67815dc

	// Calculate effective layout.
	if (inputLayout) {
	layout = inputLayout;
	} else if (!width && !height) {
	layout = Layout.CONTAINER;
	} else if (height == 'fluid') {
	layout = Layout.FLUID;
	} else if (height && (!width || width == 'auto')) {
	layout = Layout.FIXED_HEIGHT;
	} else if (height && width && (sizesAttr || heightsAttr)) {
	layout = Layout.RESPONSIVE;
	} else {
	layout = Layout.FIXED;
	}

[jridgewell]

I don't believe we can do this without :not(:resolved)

[jridgewell]

Need a bundle size approval.

[dreamofabear]

Please add a comment that this [width][height][sizes] and [width][height][heights] are "implicit responsive" here and below. Follow-up PR is cool too to avoid the bundle size reapproval.

[dreamofabear]

We're not handling any of the other implicit layouts either. Not sure if it's better to only fix this for implicit responsive or leave them all unfixed.

Consider leaving a note/TODO about this at least.

[jridgewell]

fixed, fixed-height, fluid and container are the missing ones. fluid isn't documented on https://amp.dev/documentation/guides-and-tutorials/learn/amp-html-layout/#layout, so lets ignore it.

fixed and fixed-height are implicit based on height and width only. Unfortunately, that's very generic, and there are non-amp elmeents that fit that:

• width + height
  • amp-script > canvas
  • SVG > *
  • td
  • th
  • input
• width
  • table

And container conflicts with basically everything.

I'm not sure we want to apply these styles to those elements.

I'll add a comment.

[dreamofabear]

Ok, thanks for looking into it.