Experiment for amp-sidebar #2788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
camelburrito
force-pushed
the
sidebar_prs
branch
from
41f9599 to
9180815
Compare
| // Amp Sidebar | ||
| { | ||
| id: 'amp-sidebar', | ||
| name: 'Amp Sidebar', |
|
LGTM with a couple of requests. |
camelburrito
force-pushed
the
sidebar_prs
branch
2 times, most recently
from
0d2dfe2 to
22a6edd
Compare
|
PTAL |
camelburrito
force-pushed
the
sidebar_prs
branch
from
22a6edd to
2eb73d1
Compare
| </tr> | ||
| <tr> | ||
| <td width="40%"><strong>Availability</strong></td> | ||
| <td>Work in progress.</td> |
There was a problem hiding this comment.
Let's keep "work in progress". But since experiment is already defined, let's also add the experimental part here as well. You can split them all with divs - that'd be just fine.
|
LGTM with one comment. Go ahead and merge once addressed. |
camelburrito
force-pushed
the
sidebar_prs
branch
from
2eb73d1 to
6a8359a
Compare
|
I signed it! |
1 similar comment
|
I signed it! |
This was referenced Apr 10, 2016
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.