🚀 Transformer for removing AMP devAssert, working on existing known cases #27821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erwinmombay
reviewed
Apr 17, 2020
| if (innerCallExpression) { | ||
| const evalutedDevAssert = evaluateDevAssert(innerCallExpression); | ||
| if (!evalutedDevAssert.confident) { | ||
| return; |
There was a problem hiding this comment.
should we return a boolean here? return false
| */ | ||
|
|
||
| /** | ||
| * Is a MemberExpression "thenable", `foo().then(() => {});` |
There was a problem hiding this comment.
Isn't this just asking if the expression is a promise or not? What else would be "thenable" besides a promise?
|
Drive-by comment to say thanks for working on this PR, which will have the cascading effect of improving several aspects of our compilation toolchain. Some context:
|
|
Likely won’t be able to work on this for some time, but this PR might be a good jumping off point for someone to complete the work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This WIP plugin is ready for review, marked as a draft since it's not yet tied into the development process.