intersect-resources: Fix incorrect pre-layout assumption #27684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samouri
reviewed
Apr 10, 2020
| // With IntersectionObserver, peek at the premeasured rect to see | ||
| // if the resource is still displayed (has a non-zero size). | ||
| // The premeasured rect is most analogous to an immediate measure. | ||
| if (resource.hasBeenPremeasured()) { |
There was a problem hiding this comment.
Am I right in thinking this is to catch the case where the IO has fired and inserted the premeasuredRect but the discoverWork block of the pass hasn't happened yet? Therefore we are trying to catch cases that have hidden themselves in the meantime
samouri
approved these changes
Apr 10, 2020
test/unit/test-resources.js
Outdated
| /* usePremeasuredRect */ true | ||
| ); | ||
| expect(resource1.layoutCanceled).to.be.calledOnce; | ||
| expect(resource1.getState()).to.equal(ResourceState.LAYOUT_SCHEDULED); |
There was a problem hiding this comment.
doesn't resource.layoutCancelled() set the resource state to either READY_FOR_LAYOUT or NOT_LAID_OUT?
There was a problem hiding this comment.
It does, but I stubbed it so the function becomes a no-op.
Changed to spy and updated this state. Good eye.
This was referenced Dec 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #25428.
More closely mimic the classical behavior of "explicit measure before layout" by checking if there's an unprocessed, "premeasured rect" from a more recent intersection callback.
Noticed this potential issue in examples/everything.amp.html in an
amp-ad > amp-analyticselement that starts with size 1x1 and then gets hidden.