Add Twitter background SVG to amp-social-share CSS (Issue #2628) #2667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/to @paul-matthews for review. |
|
The twitter logo now fills too much of the button (on chrome at least)
|
|
Feels a little strange to me to add padding in the SVG itself, rather than around the element's background?
|
|
The size of the Twitter icon is somewhat addressed in this PR: #2666
Should the SVG instead have top and bottom padding that would make it the same height as the Pinterest icon? |
|
Pushed a new commit that matches the Twitter height to the Pinterest height:
|
|
Thanks, @jsit. This looks good. Could you please squash your commits so I can merge? |
|
All set, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.