Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ <amp-next-page> v2 default and templated separator elements #26413

Merged
merged 29 commits into from
Jan 31, 2020

Conversation

wassgha
Copy link
Contributor

@wassgha wassgha commented Jan 20, 2020

Screenshot

Screen Shot 2020-01-20 at 10 59 19 AM

Changes

  • Implements an improved default UI for the separator pill (delimiting the end of an article and the start of the next) as designed here.
  • Implements templating for custom separator elements which provides the title, url and image of the next article. Example:
<div separator class="amp-next-page-default-separator">
     <template type="amp-mustache">
          <div class="separator-content">
            <amp-img src={{image}} layout="fixed" height="16" width="16"></amp-img>
            <span>Next article: {{title}}</span>
          </div>
    </template>
</div>

Todo

  • Add unit tests

@wassgha wassgha force-pushed the amp-next-page-v2separators branch from 0a39ed3 to 6a55cff Compare January 20, 2020 20:07
@wassgha wassgha marked this pull request as ready for review January 21, 2020 23:47
@wassgha wassgha requested a review from alanorozco January 24, 2020 01:34
@wassgha
Copy link
Contributor Author

wassgha commented Jan 24, 2020

/cc @alanorozco @caroqliu this one should be ready now :)

@wassgha wassgha force-pushed the amp-next-page-v2separators branch from 8625b5a to 4c182f8 Compare January 24, 2020 05:43
extensions/amp-next-page/1.0/page.js Outdated Show resolved Hide resolved
extensions/amp-next-page/1.0/service.js Outdated Show resolved Hide resolved
extensions/amp-next-page/1.0/service.js Outdated Show resolved Hide resolved
extensions/amp-next-page/1.0/service.js Show resolved Hide resolved
extensions/amp-next-page/1.0/test/test-amp-next-page.js Outdated Show resolved Hide resolved
extensions/amp-next-page/1.0/test/test-amp-next-page.js Outdated Show resolved Hide resolved
@wassgha wassgha requested a review from caroqliu January 29, 2020 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants