Ensure that all extensions are processed #2639
Conversation
dvoytenko
changed the title
dvoytenko
changed the title
|
Ready for review: /cc @erwinmombay @jridgewell @mkhatib @sriramkrish85 |
| @@ -64,6 +65,7 @@ export function waitForExtensions(win) { | |||
| */ | |||
| export function includedExtensions(win) { | |||
| const document = win.document; | |||
| dev.assert(document.body); | |||
There was a problem hiding this comment.
Seems very useful. The good thing about dev.assert is that one can have many of them without guilt.
|
LGTM with some comments. |
| * @param {function()} callback | ||
| */ | ||
| export function waitForChild(parent, checkFunc, callback) { | ||
| if (checkFunc()) { |
There was a problem hiding this comment.
pass in parent to checkFunc to follow all other predicate type signatures. not useful in this case since you have a ref to parent but could see it being useful in other scenarios. (might also be useful to pass it into callback)
|
LGTM per @cramforce requests |
Ensure that all extensions are processed
|
Downintegrate into canary? |
|
In canary now. |
|
Is this fix live? We believe we've seen #2630 again today. |
|
@quarterto Yes, it's live. And our monitoring shows no errors of this kind again. If you do think it's happening - let me know and I'll do more research in case there might be something else. |
Fixes #2630.