♻️ Add module / CJS and types to purifier npm package

[fstanis]

No description provided.

[jridgewell]

/to @choumx

[dreamofabear]

Is only having an "mjs" output typical?

[samouri]

My impression was that main: should be CJS and module: is normally mjs.

From Rollup's documentation:

To make sure your ES modules are immediately usable by tools that work with CommonJS such as Node.js and webpack, you can use Rollup to compile to UMD or CommonJS format, and then point to that compiled version with the main property in your package.json file. If your package.json file also has a module field, ESM-aware tools like Rollup and webpack 2+ will import the ES module version directly.

[fstanis]

Nice, didn't know this. Added CJS output now and used main and module in package.json.

[dreamofabear]

Looks like this was a bridge until Node.js supported ES6 modules: https://nodejs.org/api/esm.html#esm_dual_commonjs_es_module_packages

[fstanis]

Reading a bit into this, it seems the module + main approach @samouri suggested is still best, since Node.js will just ignore module and use main. The solution from nodejs.org to have a wrapper instead seems only useful to allow ESM support in Node (which is still experimental in LTS) and I fear it will cause complications when used in a browser.

TLDR: I see no real advantages in having an ESM version in Node (for now).

[dreamofabear]

Agreed, just sharing for anyone who was also curious.

[fstanis]

Ah, got it, sorry I misunderstood your previous comment.

[fstanis]

Update: it seems passing doc.defaultView instead of self is generally a bad idea: defaultView may be unset and this makes DOMPurify think the library is not running in a real browser, making it a singleton.