Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

please add i-mobile 3p amp-ad support #2550

Merged
merged 1 commit into from
Mar 12, 2016
Merged

Conversation

imobiletmp
Copy link
Contributor

Please add i-mobile 3p amp-ad support

We have a Google Corporate CLA.
Our CLA: i-mobile Co.,Ltd
Our company name: i-mobile Co.,Ltd

Thanks in advance

@imobiletmp
Copy link
Contributor Author

@cramforce Hi sorry for the inconvenience. We have recreated our new pull req since we messed up something in #2470

We would appreciate it very much if you could have it double checked. Thanks again!

@cramforce
Copy link
Member

LGTM

cramforce added a commit that referenced this pull request Mar 12, 2016
please add i-mobile 3p amp-ad support
@cramforce cramforce merged commit b29664d into ampproject:master Mar 12, 2016
@imobiletmp
Copy link
Contributor Author

@cramforce Hi! Would you please let us know when will the next stable revision ("latest release") be released? Our changeset has been in dev-channel for two weeks and we want to figure out a timeline for our amp business. Thanks a lot!!

@cramforce
Copy link
Member

Probably happened today. CC @ErwinM

On Thu, Mar 24, 2016 at 8:51 PM, imobile notifications@github.com wrote:

@cramforce https://github.com/cramforce Hi! Would you please let us
know when will the next stable revision ("latest release") be released? Our
changeset has been in dev-channel for two weeks and we want to figure out a
timeline for our amp business. Thanks a lot!!


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#2550 (comment)

@imobiletmp
Copy link
Contributor Author

@erwinmombay Hi! Would you please let us know when will the next stable revision ("latest release") be released? Our changeset has been in dev-channel for two weeks and we want to figure out a timeline for our amp business. Thanks a lot!!

@imobiletmp
Copy link
Contributor Author

@cramforce
Hi sir! We are planning to integrate our ad tracking and targeting features into amp system. We want to dig out a best practice and we have some options now:

  1. Add tracking and targeting logic in amp-ad approach
  2. Create our own analytics vendor and use built-in amp-analytics tag. (But we don't want to expose our analytics engine to public so we are getting confused)
  3. Is there another approach?

We really want to hear from your advises and they will be very important to our business. Thanks in advance!

@dvoytenko
Copy link
Contributor

/cc @avimehta @kashyapnitin @rudygalfi

@rudygalfi
Copy link
Contributor

The amp-analytics tag is intended to be used directly by the publisher. Therefore, I think if you need this to be working with your ad serving, then it should be integrated with amp-ad, which is option 1.

@avimehta
Copy link
Contributor

avimehta commented Apr 1, 2016

regarding 2): Currently amp-analytics only works on the AMP pages. If your ad is going to be in an iframe, it won't work (unless you serve your ad in amp format and include amp-analytics there). As for exposing the analytics engine details, you only need to expose the URL format and use the config attribute.

@imobiletmp
Copy link
Contributor Author

@avimehta @rudygalfi @dvoytenko Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants