Make runtime display fallback when needed. #2546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
| @@ -934,6 +934,10 @@ export function createAmpElementProto(win, name, implementationClass) { | |||
| // element, (b) some realyout is expected and (c) fallback condition would | |||
| // be rare. | |||
| this.classList.toggle('amp-notsupported', state); | |||
| const fallbackElement = this.getFallback(); | |||
There was a problem hiding this comment.
Please only search for fallback element when state == true
camelburrito
force-pushed
the
fallback
branch
2 times, most recently
from
c346ecb to
8351c86
Compare
|
PTAL |
|
LGTM |
camelburrito
pushed a commit
that referenced
this pull request
Mar 11, 2016
Make runtime display fallback when needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2261