Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Signals: correctly return zero values #23951

Merged
merged 2 commits into from
Aug 14, 2019
Merged

Conversation

dvoytenko
Copy link
Contributor

No description provided.

@dvoytenko dvoytenko requested a review from lannka August 14, 2019 21:15
test/unit/utils/test-signals.js Show resolved Hide resolved
src/utils/signals.js Outdated Show resolved Hide resolved
@dvoytenko dvoytenko merged commit 9d90a6a into ampproject:master Aug 14, 2019
@dvoytenko dvoytenko deleted the ampdoc21b branch August 14, 2019 22:42
thekorn pushed a commit to edelight/amphtml that referenced this pull request Sep 11, 2019
* Signals: correctly return zero values

* review fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants