amp-bind: Wait for init before scanAndApply #21763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jridgewell
approved these changes
Apr 8, 2019
extensions/amp-bind/0.1/bind-impl.js
Outdated
| @@ -381,6 +381,19 @@ export class Bind { | |||
| * @return {!Promise} | |||
| */ | |||
| scanAndApply(addedElements, removedElements, timeout = 2000) { | |||
| return this.initializePromise_.then(() => { | |||
| return this.rescan_(addedElements, removedElements, timeout); | |||
There was a problem hiding this comment.
Do these have to run sequentially? Can we just apply the latest rescan?
There was a problem hiding this comment.
Yea, thought about that e.g. skip elements with attribute i-amphtml-binding during tree walk.
However, initialization also looks for and sets up amp-bind-macro which is needed if the rescanned contents references it. So we'd need to extract that first.
Added a TODO so we can revisit later.
dreamofabear
pushed a commit
that referenced
this pull request
Apr 10, 2019
* Wait for bind.init before scanAndApply. * Add todo.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes race condition that can result in duplicate binding records e.g. in the case where amp-list renders before amp-bind's tree walk completes.