✨ Create whitelist for amp-viewer-assistance.updateActionState actionStatus #21630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: I9aeff992b2cde5215463a1f4ad717f7426818498
Change-Id: I9147bfe84b34bbe5ed0e86c59155cdf51e972cc6
dreamofabear
reviewed
Apr 1, 2019
| */ | ||
| isValidActionStatusArgs_(args) { | ||
| const update = args['update']; | ||
| if (!update || !update['actionStatus']) { |
There was a problem hiding this comment.
Hm, not sure we support object literals outside of AMP.setState (syntax). What would this look like in HTML?
<!-- Is this the intention? -->
<button on="tap:amp-viewer-assistance.updateActionStatus(update={actionStatus: ACTIVE_ACTION_STATUS})">
<!--
Or maybe we can do this (case-insensitive)?
Uppercase and append "_ACTION_STATUS" before sending viewer message.
-->
<button on="tap:amp-viewer-assistance.updateActionStatus(status=active)">There was a problem hiding this comment.
The first example is how it's usually implemented except with the payload being passed from an event:
<form id="my-form"
action-xhr="some/XHR"
on="submit-success:amp-viewer-assistance.updateActionState(update=event.response.result)">
</form>
It's also important to note that the update payload can include additional data in another field (usually result), but it is too complex to validate on the run-time side.
{
'actionStatus': 'COMPLETED_ACTION_STATUS',
'result': { ... }
}
dreamofabear
approved these changes
Apr 2, 2019
| */ | ||
| isValidActionStatusArgs_(args) { | ||
| const update = args['update']; | ||
| if (!update || !update['actionStatus']) { |
Change-Id: I4673794d9e0a469e1bf5ee7a755682b40f8ae300
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In response to this discussion comment, I created a whitelist for valid action statuses that can be passed via
amp-viewer-assistanceandupdateActionState./cc @choumx