Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨Expose the select event on amp-autocomplete. #21582

Merged
merged 5 commits into from
Mar 27, 2019
Merged

✨Expose the select event on amp-autocomplete. #21582

merged 5 commits into from
Mar 27, 2019

Conversation

caroqliu
Copy link
Contributor

  • Expose the select event on amp-autocomplete.
  • Add documentation to the md file.
  • Add a unit test for the new fireSelectEvent_ method.

cvializ
cvializ reviewed Mar 26, 2019
View reviewed changes
Copy link
Contributor

@cvializ cvializ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Just a couple comments about the docs

extensions/amp-autocomplete/amp-autocomplete.md Outdated Show resolved Hide resolved
extensions/amp-autocomplete/amp-autocomplete.md Outdated Show resolved Hide resolved
cvializ
cvializ approved these changes Mar 27, 2019
View reviewed changes
Copy link
Contributor

@cvializ cvializ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉 ping me when you're ready to merge

@cvializ cvializ merged commit 8a8daed into ampproject:master Mar 27, 2019
@omar-dulaimi
Copy link

omar-dulaimi commented Sep 7, 2020 •
edited
Loading

Hello,
Is this currently available?
I'm trying to get the selected element value from, an autocomplete input and then trigger POST submit to the backend. Currently I'm only getting what I type in the field; not the selected item. Also nothing gets sent back in the request body to the backend.
Is that by design or am I missing something?
here's the SO question url:

https://stackoverflow.com/questions/63773541/amp-form-not-submitting-form-data

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cvializ cvializ cvializ approved these changes

@gmajoulet gmajoulet Awaiting requested review from gmajoulet

@aghassemi aghassemi Awaiting requested review from aghassemi

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@caroqliu @omar-dulaimi @cvializ @googlebot