Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ add vendor navegg analytics #21376

Merged
merged 16 commits into from
Mar 28, 2019
Merged

Conversation

renankof
Copy link
Contributor

Hi,

Add vendor navegg analytics on project amphtml.

extensions/amp-analytics/0.1/vendors/navegg.js Outdated Show resolved Hide resolved
extensions/amp-analytics/0.1/vendors/navegg.js Outdated Show resolved Hide resolved
extensions/amp-analytics/0.1/vendors/navegg.js Outdated Show resolved Hide resolved
extensions/amp-analytics/0.1/vendors/navegg.js Outdated Show resolved Hide resolved
@renankof
Copy link
Contributor Author

Hi

The master branch is failing with the type test.

gulp check-types

Compiler issues for check-types.js:
extensions/amp-access/0.1/amp-access.js:653: ERROR - inconsistent return type
found : undefined
required: (Promise|null)
return;
^^^^^^^

1 error(s), 0 warning(s), 93.1% typed

@renankof
Copy link
Contributor Author

Travis has failed in timeout. There is some clear reason for this to occur?

DESCRIBE => amp-list (integration) DESCRIBE => [is-layout-container] DESCRIBE => IT => should change to layout container as on bind ✗ Error: Timeout of 15000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves.

@zhouyx
Copy link
Contributor

zhouyx commented Mar 28, 2019

Tests passed after restart. LGTM.

@zhouyx zhouyx merged commit 72949c3 into ampproject:master Mar 28, 2019
@renankof renankof deleted the navegg-analytics branch March 28, 2019 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants