Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inline env variables #2102

Merged
merged 1 commit into from
Feb 18, 2016
Merged

Inline env variables #2102

merged 1 commit into from
Feb 18, 2016

Conversation

jridgewell
Copy link
Contributor

Without this, we leave a process.env.NODE_ENV == 'production' in mode.js

It’s a wonder we don’t have 3489327499879873928479834329581793857 errors coming in every second.

Without this, we leave a `process.env.NODE_ENV == 'production'` in
`mode.js`

It’s a wonder we don’t have 3489327499879873928479834329581793857
errors coming in every second.
@cramforce
Copy link
Member

LGTM

jridgewell added a commit that referenced this pull request Feb 18, 2016
@jridgewell jridgewell merged commit 297a8f7 into ampproject:master Feb 18, 2016
@jridgewell jridgewell deleted the inline-env branch February 18, 2016 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants