-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
advertiser integration "mediaimpact" #2069
Conversation
@@ -53,6 +54,7 @@ export const adPreconnect = { | |||
'https://tpc.googlesyndication.com', | |||
], | |||
dotandads: 'https://bal.ad.dotandad.com', | |||
mediaimpact: 'https://ec-ns.sascdn.com', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can remove this. Prefetch above implies preconnect.
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
I signed it! |
Please fix lint errors and squash commits. Then this is good to go. Thanks! |
I signed it! |
I signed it! |
CLA bot can be a little bit too strict. Thanks for your "I signed it" statements, we will definitely merge. I pinged one more comment. We really need some way for users to go from "They support media impact" to "How do I get more info / talk to them?". |
How about "for further informations for this implementation please contact adtechnology@axelspringer.de or visit http://www.mediaimpact.de/"? |
+1 |
I signed it! |
added a trailing newline linted added contact details
advertiser integration "mediaimpact"
please process again, CLA is available |
I signed it!