Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

advertiser integration "mediaimpact" #2069

Merged
merged 1 commit into from
Feb 18, 2016
Merged

advertiser integration "mediaimpact" #2069

merged 1 commit into from
Feb 18, 2016

Conversation

adtechnology
Copy link

I signed it!

@@ -53,6 +54,7 @@ export const adPreconnect = {
'https://tpc.googlesyndication.com',
],
dotandads: 'https://bal.ad.dotandad.com',
mediaimpact: 'https://ec-ns.sascdn.com',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can remove this. Prefetch above implies preconnect.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@adtechnology
Copy link
Author

I signed it!

@cramforce
Copy link
Member

Please fix lint errors and squash commits. Then this is good to go.

Thanks!

@renebaudisch
Copy link
Contributor

I signed it!

@cramforce
Copy link
Member

@adtechnology
Copy link
Author

I signed it!

@cramforce
Copy link
Member

CLA bot can be a little bit too strict. Thanks for your "I signed it" statements, we will definitely merge.

I pinged one more comment. We really need some way for users to go from "They support media impact" to "How do I get more info / talk to them?".

@adtechnology
Copy link
Author

How about "for further informations for this implementation please contact adtechnology@axelspringer.de or visit http://www.mediaimpact.de/"?

@cramforce
Copy link
Member

+1

@adtechnology
Copy link
Author

I signed it!

added a trailing newline
linted
added contact details
cramforce added a commit that referenced this pull request Feb 18, 2016
advertiser integration  "mediaimpact"
@cramforce cramforce merged commit 72b730c into ampproject:master Feb 18, 2016
@adtechnology
Copy link
Author

please process again, CLA is available

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants